This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
waypoint up in the browser #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregone
force-pushed
the
ui-waypoint-up-2
branch
from
be6d8aa to
34c5f18
Compare
jgwhite
suggested changes
Sep 23, 2021
Co-authored-by: Greg Hoin <[email protected]>
This also requests the GetJobStreamResponse and displays it alongside the button. Not the end goal, but a useful stepping stone to see what’s possible.
gregone
force-pushed
the
ui-waypoint-up-2
branch
from
973ce8d to
16f4ae3
Compare
jgwhite
approved these changes
Sep 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1238
This PR basically reopens #1500 with a few modifications.Because of some technical constraints, the "Waypoint Up" button will not be available to everyone.
Users will only see it if:
DataSourceset upDataSourcePollis not enabled (otherwise "Up" automatically runs)Example (fils to deploy for other reasons, but you get the idea):
up.mov