This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
builtin/k8s: Introduce Ingress resource support for Kubernetes Releaser #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new resource to manage a Waypoint release with using Ingress. It creates an ingress resource that's associated with a service backend for a deployment.
This was referenced Sep 8, 2021
mitchellh
reviewed
Sep 8, 2021
Simplify the if-statement preflight config checks
evanphx
suggested changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor thing about some enum-like values.
izaaklauer
reviewed
Sep 10, 2021
izaaklauer
reviewed
Sep 10, 2021
izaaklauer
approved these changes
Sep 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new config option
ingress
within the Kubernetes release manager that allows users to have their releases be configured behind an ingress resource that accepts traffic from an ingress controller in their cluster.Fixes #889
This doesn't have to be gated to 0.6.0, it can be released with the next minor.
Some example apps: