This repository was archived by the owner on Jan 8, 2024. It is now read-only.
cli/uninstall: Add more validation to requested platform for uninstall #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the CLI uninstall command assumed that the platform requested matched the server platform. This could be confusing if a user has both a docker platform server and a local server from `waypoint server run`. This commit adds some extra validation with the platform requested by loading the server platform and taking into account what platform was requested. This commit also changes the hard requirement that the uninstall command needs a platform flag. If a server context has a platform set, and no platform flag was requested, use that platform instead. Note that the platform flag, if requested, always overrides what the server context has. This is because some early versions of Waypoint do not set the Platform context. If the flag and server platform conflift, we'll print a note to say we're honoring the platform flag requested. Fixes #2046
krantzinator
approved these changes
Aug 16, 2021
evanphx
suggested changes
Aug 16, 2021
izaaklauer
approved these changes
Aug 17, 2021
briancain
force-pushed
the
bug/cli/uninstall-validate-context-before-uninstall
branch
from
3af4dba to
32e1968
Compare
evanphx
approved these changes
Aug 17, 2021
briancain
deleted the
bug/cli/uninstall-validate-context-before-uninstall
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the CLI uninstall command assumed that the
platform requested matched the server platform. This could be confusing
if a user has both a docker platform server and a local server from
waypoint server run. This commit adds some extra validation with theplatform requested by loading the server platform and taking into
account what platform was requested.
This commit also changes the hard requirement that the uninstall
command needs a platform flag. If a server context has a platform set,
and no platform flag was requested, use that platform instead. Note
that the platform flag, if requested, always overrides what the server
context has. This is because some early versions of Waypoint do
not set the Platform context. If the flag and server platform conflict,
we'll print a note to say we're honoring the platform flag requested.
Fixes #2046
Screenshot of an example when no server platform was set or requested, and then the warning for if no server platform was set but a platform flag was requested: