This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
cli/status: fix broken output when no generated time is set #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
commented
Aug 13, 2021
| @@ -947,12 +947,12 @@ func (c *StatusCommand) FormatStatusReportComplete( | |||
| statusReportComplete = "? UNKNOWN" | |||
| } | |||
|
|
|||
| t, err := ptypes.Timestamp(statusReport.GeneratedTime) | |||
There was a problem hiding this comment.
ptypes.Timestamp is deprecated https://pkg.go.dev/github.com/golang/protobuf/ptypes#Timestamp
briancain
approved these changes
Aug 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a status report is returned without
GeneratedTimeset, the CLI will fail to parse it:In this PR we check for a valid time. If it's not valid, we insert
(unknown)as a placeholder