This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 330
Improvement: Plugin/Docker: Enables image build for specified platform #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
suggested changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @xiaolin-ninja ! I know this is still a draft, but it looks straightforward enough I figured I'd leave a review 😄 Looks good overall, just a few minor comments! ✨
38cc69c
to
bdecf18
Compare
izaaklauer
reviewed
Aug 3, 2021
izaaklauer
approved these changes
Aug 4, 2021
df14fc4
to
7ca6b52
Compare
I rebased this PR to fixup the merge conflict, fyi! |
briancain
approved these changes
Aug 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1881. Enables a platform HCL arg that is equivalent to
docker build --platform
flag. This only works with buildkit on (will fail with error).Usage:
Add platform in
waypoint.hcl
How to verify this works:
waypoint build
docker inspect <docker image>
output should containMerge after #1937.
Issue filed with Docker/Moby so that it may work without buildkit in the future.
🍐 with @izaaklauer thanks!