-
Notifications
You must be signed in to change notification settings - Fork 329
Conversation
8304b96
to
ae4de76
Compare
ae4de76
to
8a369ff
Compare
8a369ff
to
2540fd9
Compare
2540fd9
to
745d0cd
Compare
745d0cd
to
0bf4aea
Compare
e452342
to
9a43a61
Compare
9a43a61
to
b6a5261
Compare
6c469ae
to
0afe062
Compare
0afe062
to
e3d5d59
Compare
e3d5d59
to
ebaccdb
Compare
ebaccdb
to
9987f6e
Compare
Co-authored-by: Jamie White <[email protected]>
1028eaa
to
310e882
Compare
super.setupController(controller, model, transition); | ||
let project = this.modelFor('workspace.projects.project'); | ||
|
||
controller.project = project; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to do this without set
, given controller.project
isn’t a @tracked
property? I would guess it’s OK but I’m not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question 🤔. I'll verify and update tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looked into it: it's fine and the route updates the controller properly every time. The only concern would be if we were interacting with this controller from outside the route, but we're not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 🎉
I left one tiny comment which I think we should fix but it’s not worth holding up the PR for.
Update return value
a1779d1
to
b3c1ef8
Compare
Fixes #1512
This PR adds Config Variables management to the project settings screen.
The list view displays both static and dynamic variables, with the latter in an abridged form, but only static variables are editable.
Editable attributes:
Variables can also be edited from the UI.
Screen.Recording.2021-09-03.at.13.20.29.mov