Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

ui: display status reports on deployments #1559

Merged
merged 12 commits into from
Jun 3, 2021
Merged

ui: display status reports on deployments #1559

merged 12 commits into from
Jun 3, 2021

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented May 31, 2021 •
edited
Loading

What is this?

Fixes #1237

This PR adds badges to deployments indicating the result of Waypoint’s latest status report (aka health check).

What’s the plan?

  • Create <StatusBadge>
  • Add Mirage layer
  • Load status reports
  • Display status report badge on deployment list view (where available)
  • Display status report badge on deployment detail view (where available)
  • Add test coverage
  • Add changelog entry

What are we saving for a future PR/release?

What does it look like?

image

image

How do I verify it?

Using Mirage

  1. Check out the branch: 
    git checkout ui-health-checks-integration
  2. Boot the dev server 
    cd ui && ember serve
  3. Visit the demo deployment list view
  4. Verify you see status badges
  5. Visit the demo deployment detail view
  6. Verify you see a status badge

For realsies

  1. Check out the branch: 
    git checkout ui-health-checks-integration
  2. Build the ember app 
    (cd ui && make)
  3. Bundle the static assets 
    make static-assets
  4. Build the dev server 
    make docker/server
  5. Build the CLI 
    make bin
  6. Install waypoint on your platform of choice, i.e. 
    ./waypoint install -platform=kubernetes -accept-tos -k8s-server-image=waypoint:dev
  7. Open the UI 
    ./waypoint ui -authenticate
  8. Try out an example app of your choice (i.e. kubernetes/nodejs)
  9. Verify you see status badges

@jgwhite jgwhite added the ui label May 31, 2021
@briancain briancain self-requested a review June 1, 2021 14:59
@briancain briancain added the pr/no-changelog No automatic changelog entry required for this pull request label Jun 1, 2021
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from 7767a19 to ee023e8 Compare June 2, 2021 10:16
@jgwhite jgwhite changed the base branch from main to ui-gen-ts-status-report-health June 2, 2021 10:16
Base automatically changed from ui-gen-ts-status-report-health to main June 2, 2021 19:04
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from b949881 to b048cd0 Compare June 2, 2021 19:37
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from 060020f to d11ee4f Compare June 2, 2021 21:17
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from d11ee4f to 533146a Compare June 2, 2021 21:25
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from 533146a to defc69b Compare June 2, 2021 21:28
@briancain briancain added this to the 0.4.0 milestone Jun 2, 2021
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from defc69b to 59fd4de Compare June 2, 2021 21:37
@jgwhite jgwhite changed the title ui: display health checks ui: display health checks on deployments list Jun 2, 2021
@jgwhite jgwhite changed the title ui: display health checks on deployments list ui: display health checks on deployments Jun 2, 2021
briancain
briancain reviewed Jun 2, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give a proper review tomorrow since you mention you have a few more TODOs, but gave this a shot locally as is stands right now and looks good to me! 🎉

@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from a2c0d24 to 90ef6cf Compare June 3, 2021 12:31
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from 90ef6cf to c563f91 Compare June 3, 2021 13:03
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from c563f91 to 239ac1d Compare June 3, 2021 13:30
@jgwhite jgwhite removed the pr/no-changelog No automatic changelog entry required for this pull request label Jun 3, 2021
@jgwhite jgwhite marked this pull request as ready for review June 3, 2021 13:59
@jgwhite jgwhite changed the title ui: display health checks on deployments ui: display status reports on deployments Jun 3, 2021
krantzinator
krantzinator approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@krantzinator krantzinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

izaaklauer
izaaklauer approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@izaaklauer izaaklauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested success scenarios locally, and it looks great! Failure scenarios are very hard to produce locally at this point - you need to get the deployment into a bad state in the time between the deployment completing and the first status check kicking off. Will be easier once we have polling.

jgwhite and others added 12 commits June 3, 2021 17:07
@jgwhite @gregone
ui: update <StatusBadge>
8aaead3 
A few different changes bundled together, in order of importance:

1. Key off human-readable health statuses (as they come from the API)
2. Expand test coverage
3. Tweak styling to better match designs
4. Microscopic copy tweak

Co-authored-by: Greg Hoin <[email protected]>
@jgwhite
ui: add ...attributes to <Card>
32e4a7b
@jgwhite @gregone
ui: force <Pds::Icon> to center align
60d240c 
Co-authored-by: Greg Hoin <[email protected]>
@jgwhite @gregone
ui: auto-fix linting issues in api service
5d58904 
Co-authored-by: Greg Hoin <[email protected]>
@jgwhite @gregone
ui: auto-fix linting issues in deployment route
4c2318f 
Co-authored-by: Greg Hoin <[email protected]>
@jgwhite
ui: fix empty-state color contrast violation
34ccbe9
@jgwhite
ui: temp fix for deployment detail h1 violation
25b26bc
@jgwhite @gregone
ui/mirage: add status-report and friends
4aafa4d 
Co-authored-by: Greg Hoin <[email protected]>
@jgwhite
ui/mirage: add a stub GetJobStream handler
d05535c
@jgwhite @gregone
ui: add status reports to deployment list items
39a4d90 
Co-authored-by: Greg Hoin <[email protected]>
@jgwhite @gregone
ui: add status report to deployment detail page
fd67ae7 
Co-authored-by: Greg Hoin <[email protected]>
@jgwhite
Add .changelog/1559.txt
db0b39c
@jgwhite jgwhite force-pushed the ui-health-checks-integration branch from 5c5f11a to db0b39c Compare June 3, 2021 15:14
briancain
briancain approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!! Looks great ❇️ ✔️

@briancain briancain merged commit b6993bd into main Jun 3, 2021
@briancain briancain deleted the ui-health-checks-integration branch June 3, 2021 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@briancain briancain briancain approved these changes

@izaaklauer izaaklauer izaaklauer approved these changes

@krantzinator krantzinator krantzinator approved these changes

Assignees

@jgwhite jgwhite

@almonk almonk

@gregone gregone

Labels
ui
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Status from health checks in UI
6 participants
@jgwhite @briancain @izaaklauer @krantzinator @almonk @gregone