Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

internal/server/singleprocess: Flaky tests #1521

Closed
krantzinator opened this issue May 20, 2021 · 3 comments
Closed

internal/server/singleprocess: Flaky tests #1521

krantzinator opened this issue May 20, 2021 · 3 comments
Assignees
@izaaklauer
Labels
tests
Milestone
0.4.x

Comments

@krantzinator
Copy link
Contributor

krantzinator commented May 20, 2021 •
edited
Loading

Describe the bug
Flaky tests in internal/server/singleprocess

Steps to Reproduce
Flakes from:

Expected behavior
Less flakes.

Waypoint Platform Versions
All.
@izaaklauer izaaklauer self-assigned this May 21, 2021
@mitchellh
Copy link
Contributor

So the fault errors are actually potentially bugs in BoltDB. They seem to pop up in any test and the stack traces are deep in Bolt. I would separate those from this issue cause thats a bigger discussion of if we want to switch to the etcd fork since they maybe have fixed this...

The others are probably real flakes that are our fault. 😄

@krantzinator
Copy link
Contributor Author

Updated to remove the fault error tests, and will put that info in our planning doc instead.

@izaaklauer izaaklauer mentioned this issue May 26, 2021
Merged
@evanphx evanphx added this to the 0.4.x milestone May 26, 2021
@evanphx
Copy link
Contributor

evanphx commented Jun 16, 2021

Given the merger of #1538, we're going to presume that these are fixed.

@evanphx evanphx closed this as completed Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@izaaklauer izaaklauer

Labels
tests
Projects
None yet
Milestone
0.4.x
Development

No branches or pull requests
4 participants
@evanphx @mitchellh @izaaklauer @krantzinator