This repository was archived by the owner on Jan 8, 2024. It is now read-only.
Specify number of deployments to retain when pruning during release #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanphx
suggested changes
Mar 24, 2021
Co-authored-by: Evan Phoenix <[email protected]>
Co-authored-by: Evan Phoenix <[email protected]>
Co-authored-by: Evan Phoenix <[email protected]>
Co-authored-by: Evan Phoenix <[email protected]>
mitchellh
force-pushed
the
feature/prune-retain
branch
from
4ad38a9 to
fe76bcc
Compare
evanphx
approved these changes
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988
This adds two new CLI flags to
upandrelease:-pruneto disable pruning completely (not recommended, defaults true to prune)-prune-retainto specify how many existing deployments to retain, defaults to "2".The
-prune-retainflag can be set to 0 to remove all previous deploys.This only allows setting this via the CLI (or very raw API) today. In the future we should investigate exposing this more completely in waypoint.hcl files, the UI, etc. But this gets in a minimal solution to help the folks in #988.