Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Fix panic from waypoint hostname delete with no hostname specified #1044

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

gulducat
Copy link
Member

@gulducat gulducat commented Feb 1, 2021

A lil order-of-operations issue resulted in an unsightly panic.

Before:

❯ waypoint hostname delete

panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
... trace ...

After:

❯ ./waypoint hostname delete
! hostname required for deletion

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 1, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the core label Feb 1, 2021
Copy link
Member

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! It seems like heroku build packs are a bit broken at the moment, so that's why the integration tests are failing. Otherwise if you sign the CLA we'll be good to merge! 😄

@gulducat gulducat force-pushed the fix-hostname-delete-with-no-arg branch from c1dfcb9 to 606de69 Compare February 1, 2021 17:37
@gulducat
Copy link
Member Author

gulducat commented Feb 1, 2021

sure thing! I did a force-push to update my author email for cla-assistant (which I'm partially responsible for operating, so really should have known to do that before making a PR 😋)

@gulducat gulducat merged commit c19fe23 into main Feb 1, 2021
@gulducat gulducat deleted the fix-hostname-delete-with-no-arg branch February 1, 2021 17:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants