Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: drop dependency on go-rootcerts #26136

Open
dolmen opened this issue Mar 25, 2024 · 2 comments · May be fixed by #29533
Open

api: drop dependency on go-rootcerts #26136

dolmen opened this issue Mar 25, 2024 · 2 comments · May be fixed by #29533
Labels
dependencies Pull requests that update a dependency file

Comments

@dolmen
Copy link

dolmen commented Mar 25, 2024

The github.com/hashicorp/go-rootcerts module doesn't seem necessary anymore with recent Go versions:

$ cd api
$ go mod graph | grep go-rootcerts          
github.com/hashicorp/vault/api github.com/hashicorp/[email protected]
github.com/hashicorp/[email protected] github.com/mitchellh/[email protected]
github.com/hashicorp/vault/[email protected] github.com/hashicorp/[email protected]
github.com/hashicorp/[email protected] github.com/mitchellh/[email protected]
$ go mod graph | grep go-homedir  
github.com/hashicorp/[email protected] github.com/mitchellh/[email protected]
github.com/hashicorp/[email protected] github.com/mitchellh/[email protected]
@ccapurso ccapurso added the dependencies Pull requests that update a dependency file label Mar 25, 2024
@dolmen
Copy link
Author

dolmen commented Jul 4, 2024 •
edited
Loading

There are only a few references to rootcerts.Config in this repo:

  • api/client.go
  • api/ssh_agent.go
  • builtin/credential/cert/backend_test.go

If I write the patch myself, is there a chance for it to be accepted?

@cipherboy cipherboy mentioned this issue Aug 23, 2024
Closed
@fatima2003 fatima2003 mentioned this issue Oct 1, 2024
Merged
@dolmen
Copy link
Author

dolmen commented Feb 10, 2025

This issue is still relevant. I'm still available to work on a patch.

@dolmen dolmen linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: drop dependency on go-rootcerts #26136 dolmen-go/hashicorp-vault
2 participants
@dolmen @ccapurso