Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for importing Service Accounts managed outside of Vault #83

Closed
mdgreenfield opened this issue Apr 1, 2020 · 2 comments
Closed

Comments

@mdgreenfield
Copy link
Contributor

I wanted to see if there had been any previous consideration to allowing creating rolesets for service accounts that are created outside of this GCP secret engine? And if not, would it be something others would find useful.

An obvious downside is that if a service account was deleted, it would break the roleset. But that is no different from the current risks of the GCP secrets engine.

My main use case which prompts this discussion is that we have multiple Vault clusters running across various cloud providers configured with the GCP secrets engine for a given GCP project. Unfortunately, with rolesets being consistently configured across all Vault clusters, this results in a large number of unused service accounts and we more quickly need to request a service account quota increase with GCP.

Being able to configure a roleset with a service account that is managed outside of this secrets engine additionally would allow us to avoid HTTP 409 conflicts of service accounts created with the same unix timestamp (see #81) and it would allow us to avoid an HTTP 409 conflict when multiple Vault clusters try to update the IAM policy on a GCP project.

@lawliet89
Copy link
Contributor

@austingebauer I think this was covered by my PR in #107

@austingebauer
Copy link
Member

Hi, @mdgreenfield! We introduced the feature that you've described here in Vault 1.8. I'm going to close this feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants