Skip to content

Conversation

@SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Oct 31, 2025

This is a rabbit hole I explored today 😅

I was trying to find a satisfying way to test changes in #37569 to workspace command autocompletion (ie 733618f and 7497796).

I've settled on testing workspace-related autocompletion with more of a unit test, but I think this change to the original test I was taking inspiration from could still be merged.

Previously I think the test only asserted that autocomplete that got no autocompletion results didn't result in an error. Now the test shows that no error happens both when autocompletion returns a result vs an empty result, and also asserts about the returned value.

Target Release

N/A

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Oct 31, 2025
@SarahFrench SarahFrench changed the title Add test coverage for workspace name autocompletion in workspace select subcommand Update test for autocompletion of top-level commands Oct 31, 2025
@SarahFrench SarahFrench marked this pull request as ready for review October 31, 2025 17:09
@SarahFrench SarahFrench requested a review from a team as a code owner October 31, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog-needed Add this to your PR if the change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant