-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
providers/google: Add google_compute_image resource #7960
Conversation
Name: d.Get("name").(string), | ||
} | ||
|
||
if v := d.Get("description"); v != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More idiomatic way to achieve the same thing may be
if v, ok := d.GetOk("description"); ok {
😉
Hi @evandbrown If you could rebase this, then we can get it tested and merged :) Thanks Paul |
5d53f18
to
f558302
Compare
@stack72 Done! Output of relevant acceptance tests:
|
@evandbrown looks like the build fails - looks like there are go vet issues P. |
@evandbrown ping - we have some go vet errors :)
|
This change introduces the google_compute_image resource, which allows Terraform users to create a bootable VM image from a raw disk tarball stored in Google Cloud Storage. The google_compute_image resource may be referenced as a boot image for a google_compute_instance.
f558302
to
87e6b4d
Compare
@stack72 That's embarrassing! Just rebased a fix that should fix... |
spot on :) Thanks! running tests now |
:) |
Will merge when travis goes green! |
Docs were originally added in #7960, but weren't added to the sidebar.
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This change introduces the google_compute_image resource, which allows
Terraform users to create a bootable VM image from a raw disk tarball
stored in Google Cloud Storage. The google_compute_image resource
may be referenced as a boot image for a google_compute_instance.