Changing AWS ELB to not ForceNew when listeners change

[robzienert]

Closes #652.

[robzienert]

retest

[robzienert]

Didn't see a retest button or action anywhere - but the build failure looks transient and unrelated to my commit. Any help?

[svanharmelen]

Done 😃

[robzienert]

Cheers, thanks!

[svanharmelen]

The approach used in other resources, is to only add the ForceNew option if it is set to true, otherwise just delete it from the schema. So in this case it would be better to just delete the line instead of setting it to false.

[svanharmelen]

One inline comment about the code change, but additionally a note that this code change on it's own doesn't seem to be enough to change the behaviour.

As the resourceAwsElbUpdate function doesn't contains any logic to update the listeners for existing ELB's, it is currently still required to create a new one when the listeners changed.

So if you want to modify this behaviour, you should also add some logic in the update func so changes are actually updated to the existing ELB.

[mitchellh]

LGTM, going to remove that one extranneous line myself. :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.