Adding colon to interpolated regex so they can be used in concats #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamdor
changed the title
lamdor
force-pushed
the
fix-interpolated-func-with-colon
branch
from
b83d769
to
e970eea
Compare
armon
added a commit
that referenced
this pull request
Jan 5, 2015
Adding colon to interpolated regex so they can be used in concats
|
Agreed. That "language" has evolved pretty far. I think eventually it will just need a lexer + BNF to properly parse into an AST instead of the growing complexity of the regex / bespoke parser evaluator. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
I don't think the regex is sustainable or at the very least, we need to come up with a list of valid characters that can be used within an interpolation. Since we now have
concat, basically the user can input any string values which we continually come up against this regex.So for now, I've just added the colon to to regex valid chars to fix my own case.