Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Base URL endpoint for GitHub Enterprise Support #6434

Merged
merged 1 commit into from May 9, 2016
Merged

Add support for the Base URL endpoint for GitHub Enterprise Support #6434

merged 1 commit into from May 9, 2016

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2016

Added logic to support changing the base API URL for GitHub. Coded so that the value is only used when provided. Updated documentation.

BaseURL is taken from https://github.com/google/go-github/blob/576fece59c05680a3862785c1f6522eefb6cb0aa/github/github.go#L81

@stack72
Copy link
Contributor

stack72 commented May 5, 2016

Hi @Betakevin

Is this still a WIP?

P.

@ghost ghost changed the title Add support for the Base URL endpoint for GitHub Enterprise Support [WIP] Add support for the Base URL endpoint for GitHub Enterprise Support May 5, 2016
@stack72
Copy link
Contributor

stack72 commented May 9, 2016

Hi @Betakevin

This looks like a nice addition - thanks so much for the PR here

Paul

@stack72 stack72 merged commit 0cec1c1 into hashicorp:master May 9, 2016
cristicalin pushed a commit to cristicalin/terraform that referenced this pull request May 24, 2016
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants