Triton NICs #6418
Triton NICs #6418
Conversation
| @@ -108,17 +109,53 @@ func resourceMachine() *schema.Resource { | |||
| Type: schema.TypeString, | |||
| Computed: true, | |||
| }, | |||
| "networks": { | |||
There was a problem hiding this comment.
Hi @BrianHicks
Dropping networks will remove backward compatibility. Therefore we need to either:
- Have a migration in place (e.g. https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_instance_migrate.go)
or - Leave the field in and add the deprecated tag (https://github.com/hashicorp/terraform/blob/master/builtin/providers/cloudstack/resource_cloudstack_nic.go)
If you go for #2 you need to be able to handle the code either way
There was a problem hiding this comment.
Yes, see line 193. The code handles both but prints a warning because the field is marked as deprecated. I just added nic above network, which I guess shows up weird in this diff.
There was a problem hiding this comment.
Yup just a weird diff artefact. Well done git!
|
LGTM - thanks @BrianHicks! As an aside we now have the Triton tests running every night now, so this will get a few runs before making it into 0.6.16. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Replace networks with NICs. NICs don't have the odd behaviour of having to change networks on every apply.
Tests pass for me, both manually and automated. But I've seen them fail randomly, so if someone could verify that the test strategy looks good before merging I'd appreciate it.