Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fixes issue where an update for an aws_elastic_beanstalk_environment resource would ignore the wait_for_ready_timeout option. #6358

Merged

Conversation

dharrisio
Copy link
Contributor

This addresses issue brought up in #6242 where the wait_for_ready_timeout option is ignored, originally done in #6342

Tests

=== RUN   TestAccAWSBeanstalkEnv_basic
--- PASS: TestAccAWSBeanstalkEnv_basic (376.01s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    376.019s

@stack72
Copy link
Contributor

stack72 commented Apr 26, 2016

Another nice addition @dharrisio. Thanks for this

LGTM pending Travis build

@dharrisio
Copy link
Contributor Author

From looking at the Travis failure, it doesn't look like this was related to the aws provider. From the logs it looks like it was

FAIL github.com/hashicorp/terraform/command

Any ideas here @stack72?

@stack72
Copy link
Contributor

stack72 commented Apr 26, 2016

@dharrisio, this isn't your change. This is being worked on ATM by @phinze. We will trigger another build soon

@phinze
Copy link
Contributor

phinze commented Apr 26, 2016

@dharrisio if you rebase on master that failure should go away - sorry for the hiccup! 😁

@dharrisio
Copy link
Contributor Author

@phinze No problem! Rebasing and pushing in a few seconds here.

…` resource would ignore the `wait_for_ready_timeout` option.
@dharrisio dharrisio force-pushed the b-aws-elastic-beanstalk-fix-state-timeout branch from a5ed0df to 40e7d0b Compare April 26, 2016 20:58
@stack72 stack72 merged commit 635fced into hashicorp:master Apr 26, 2016
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants