Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Use ID in lookup for AWS KMS Aliases #6328

Merged
merged 1 commit into from
Apr 25, 2016

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 25, 2016

Fixes a bug when using name_prefix in the AWS KMS Alias resource; we set the name generated as the ID, but then use the value from d.Get("name") for lookup. If we're using a prefix, this value is empty.

Fixes TestAccAWSKmsAlias_basic here

@stack72
Copy link
Contributor

stack72 commented Apr 25, 2016

Nice fix - LGTM!

@catsby catsby merged commit 9ffe792 into master Apr 25, 2016
@catsby catsby deleted the b-aws-kms-alias-fix branch April 25, 2016 16:53
@ghost
Copy link

ghost commented Apr 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants