provider/aws: Support eventually consistent aws_security_group_rule #6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Preferring slower but consistent runs when AWS API calls do not properly return the SG Rule in the list of ingress/egress rules. - Testing has shown that several times that we had to exceed 20 attempts before the SG was actually returned
- Adjusting to use resource.Retry - Extract lookup method for matching ipPermissions set
…y-Group-Rule-Evn-Consis
|
Checked this out locally, looks good! All the acceptance tests passed for me, so we'll pull this in. Nice work! |
|
Great, thanks! |
|
Great! |
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
…ashicorp#6325) * TF-6256 - SG Rule Retry - Preferring slower but consistent runs when AWS API calls do not properly return the SG Rule in the list of ingress/egress rules. - Testing has shown that several times that we had to exceed 20 attempts before the SG was actually returned * TF-6256 - Refactor of rule lookup - Adjusting to use resource.Retry - Extract lookup method for matching ipPermissions set
bigkraig
pushed a commit
to ticketmaster/terraform
that referenced
this pull request
May 5, 2016
…ashicorp#6325) * TF-6256 - SG Rule Retry - Preferring slower but consistent runs when AWS API calls do not properly return the SG Rule in the list of ingress/egress rules. - Testing has shown that several times that we had to exceed 20 attempts before the SG was actually returned * TF-6256 - Refactor of rule lookup - Adjusting to use resource.Retry - Extract lookup method for matching ipPermissions set
xsellier
pushed a commit
to xsellier/terraform
that referenced
this pull request
May 17, 2016
…ashicorp#6325) * TF-6256 - SG Rule Retry - Preferring slower but consistent runs when AWS API calls do not properly return the SG Rule in the list of ingress/egress rules. - Testing has shown that several times that we had to exceed 20 attempts before the SG was actually returned * TF-6256 - Refactor of rule lookup - Adjusting to use resource.Retry - Extract lookup method for matching ipPermissions set
cristicalin
pushed a commit
to cristicalin/terraform
that referenced
this pull request
May 24, 2016
…ashicorp#6325) * TF-6256 - SG Rule Retry - Preferring slower but consistent runs when AWS API calls do not properly return the SG Rule in the list of ingress/egress rules. - Testing has shown that several times that we had to exceed 20 attempts before the SG was actually returned * TF-6256 - Refactor of rule lookup - Adjusting to use resource.Retry - Extract lookup method for matching ipPermissions set
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found that there are several instances when AWS API is busy that the SG describe will not return the appropriate set of permissions. We have observed this taking over 2 minutes in the past.
NOTE: There are a few things that I could use another set of eyes on or clarification around:
TestAccAWSSecurityGroupRule_Egresstest fails for me, but it also fails on the master branch without any of my modifications as well.resourceAwsSecurityGroupRuleReadto lookup the item after creation does quite a bit there. I was unclear why the state file was mapped to a ipPermission with the expandIPPerm, an explicit match was found and then those same values were reset on the state file with the values from the EC2 ip permission. If this is significant I could not understand whyFixes #6256