provider/aws: Add support for api_gateway_account

[radeksimko]

I've reached out to Amazon to get a confirmation whether it's really impossible to reset CloudWatch Role ARN to empty string. That's why I marked this as WIP, otherwise it works ok (within the limitations of the API). see below

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSAPIGatewayAccount_basic'

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSAPIGatewayAccount_basic -timeout 120m
=== RUN   TestAccAWSAPIGatewayAccount_basic
--- PASS: TestAccAWSAPIGatewayAccount_basic (61.86s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    61.880s

[radeksimko]

I received response from AWS support confirming my findings - i.e. it's not possible to remove an ARN or make it blank. 😢

Hi,

From my testing it doesn't look like you can remove this. While this shouldn't be a huge security issue as it's only logging events within that particular APIGW region, I will forward this to our APIGW team to look at as a feature request moving forward.

This is therefore ready for review/merge.

[stack72]

Is there a chance that someone deleting an ApiGatewayAccount (using the AWS Console) could cause an error here? Should we check for a 404 and remove from state if so?

[radeksimko]

There is no way to delete the "account" even through the AWS Console... so no.

[stack72]

Few small questions about the PR and 1 nit pick (about adding a test) but that can be fixed later if needed :)

[stack72]

I guess we can merge this for now and then figure out the leaked resources part later? The tests pass (As below) so this LGTM!

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSAPIGatewayAccount_basic'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSAPIGatewayAccount_basic -timeout 120m
=== RUN   TestAccAWSAPIGatewayAccount_basic
--- PASS: TestAccAWSAPIGatewayAccount_basic (57.28s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    57.298s

[radeksimko]

Let me just add two tests (empty resource with "empty" update API call + flattenApiGatewayThrottleSettings) and then you can give it final review & merge.

Hopefully I'll get to it tomorrow.

[stack72]

👍

[radeksimko]

Both tests added per comments. This is now ready for final review @stack72

[stack72]

@radeksimko this is awesome :) Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.