Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: All open OpsWorks issues, with PRs, targeted for inclusion in v0.6.15? #6245

Closed
5 of 6 tasks
u2mejc opened this issue Apr 19, 2016 · 10 comments
Closed
5 of 6 tasks

Comments

@u2mejc
Copy link
Contributor

u2mejc commented Apr 19, 2016

This is a consolidation of every [known] OpsWorks issue broken v0.6.14, each with a PR, with the hope that we can get OpsWorks stable in 0.6.15! 🚀 Also if anyone sees a PR / Issue I missed, please let me know.

    lifecycle {
        ignore_changes = ["custom_cookbooks_source.0.ssh_key"]
    }
@janschumann
Copy link
Contributor

janschumann commented Apr 19, 2016

@u2mejc As mentioned in #4419, some attributes of an aws_opsworks_application resource are not passed to the underlying go sdk for some reason. Or at least I believe that this is the case, as a manual call to the aws api works as documented.

E.g. the attribute document_root is always empty. That is when creating that resource and also when refreshing the state after editing that resource manually.

This might be related to #5907.

Can you confirm, that you can not reproduce this behavior?

@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 21, 2016

Thank you @catsby!

@janschumann I wasn't able to reproduce it previously, I believe it's because I'm using custom layers only. I poked at the ruby issue briefly and it's a weird one. It actually sends the boolean mentioned in #5907 as a 1 instead of a true. Then when plan is ran again, it fails to compare that false doesn't match what is in the resource.

I'll poke at it tomorrow, but if you or anyone else has a lead on the issue, please shoot up a PR, I don't presently have one staged for that issue.

@apparentlymart apparentlymart changed the title aws/provider - All open OpsWorks issues, with PRs, targeted for inclusion in v0.6.15? provider/aws: All open OpsWorks issues, with PRs, targeted for inclusion in v0.6.15? Apr 22, 2016
@u2mejc
Copy link
Contributor Author

u2mejc commented Apr 25, 2016

UPDATE: v0.6.15 has been released, and Opsworks support has been radically improved. Instance and stack creation are now supported, a nasty regression in creating stacks has been resolved, failing to update stacks was resolved, and plenty of other small feature / issues.

Still the biggest outstanding issue now is language or app specific layers are not being transmitted properly to AWS and silently fail to be properly diff'ed on subsequent runs. #5907

I'm also going to close the s3 issue PR. I'm not feeling good traction on wrapping my head around the issue, and I want to make sure that anyone who wants to work on the issue isn't turned away by seeing my open WIP.

@ericgoedtel
Copy link

@janschumann Were you able to find a fix to the problem regarding document_root? I am seeing a similar if not identical problem. terraform is not setting or fetching the value of document root and saving it to tfstate.

@janschumann
Copy link
Contributor

janschumann commented Dec 1, 2016

UPDATE: as off 0.7.13 the document_root problem still exists. I will work on this now.

@u2mejc @ericgoedtel

@stack72
Copy link
Contributor

stack72 commented Dec 2, 2016

What is the status of the rest of this ticket?

Paul

@janschumann
Copy link
Contributor

@stack72 sorry, just seen this right now. I will try to figure out the status and also look if there are any other opsworks related issues.

@janschumann
Copy link
Contributor

All other issues, including all opsworks application issues regarding additional attributes (#10477) should be fixed.

@stack72
Copy link
Contributor

stack72 commented Dec 12, 2016

the PR (#10669) from @janschumann shows that this can now be closed - thanks for all the work here @u2mejc and @janschumann :)

@stack72 stack72 closed this as completed Dec 12, 2016
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants