-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLC update: tests and alias #5785
Conversation
Hi @ack - thanks for this! I see If that's the case, I think we should keep a file there with a comment pointing to where it is tested, just because the "every resource has a test file sibling" is such a pattern for us. |
fa3c9ec
to
d9104f7
Compare
gotcha, resurrected an empty test |
LGTM |
Congrats on your first merge 😄 There's a user facing change here - so let's have you add a line to the changelog under IMPROVEMENTS about the fact that you can now set an account alias. You can follow the patterns elsewhere in the file and commit right to master. Most of us just use the GitHub |
Cheers for the quick turnaround @ack... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
customer requested account alias be optionally available. updated tests as per previous PR discussion