Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/azurerm: Adding azurerm_template_deployment resource #5758

Merged
merged 2 commits into from
Mar 21, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Mar 21, 2016

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMTemplateDeployment_basic' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMTemplateDeployment_basic -timeout 120m
=== RUN   TestAccAzureRMTemplateDeployment_basic
--- PASS: TestAccAzureRMTemplateDeployment_basic (506.67s)
=== RUN   TestAccAzureRMTemplateDeployment_withParams
--- PASS: TestAccAzureRMTemplateDeployment_withParams (389.67s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/azurerm    895.67s


name := d.Get("name").(string)
resGroup := d.Get("resource_group_name").(string)
deployment_mode := d.Get("deployment_mode").(string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go style nit, should be deploymentMode

@stack72 stack72 changed the title [WIP] provider/azurerm: Adding azurerm_template_deployment resource provider/azurerm: Adding azurerm_template_deployment resource Mar 21, 2016
log.Printf("[DEBUG] Waiting for Template Deployment (%s) to become available", name)
stateConf := &resource.StateChangeConf{
Pending: []string{"Creating", "Updating", "Accepted", "Running"},
Target: []string{"Succeeded"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This casing feels brittle - I think we should make this all lower and have the RefreshFunc return strings.ToLower() of the status.

* `template_body` - (Optional) Specifies the JSON definition for the template.

* `parameters` - (Optional) Specifies the name and value pairs that define the deployment parameters for the template.
* `deploymnet_mode` - (Optional) Specifies the mode that is used to deploy resources. This value could be either `Incremental` or `Complete`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newlines here might cause some funky markdown.

@phinze
Copy link
Contributor

phinze commented Mar 21, 2016

Two nits and a rebase to fix travis, this LGTM generally tho!

phinze added a commit that referenced this pull request Mar 21, 2016
provider/azurerm: Adding `azurerm_template_deployment` resource
@phinze phinze merged commit 1d6cecf into hashicorp:master Mar 21, 2016
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants