provider/vsphere: provide host to provisioner connections

[higebu]

Provide host to provisioner connections to enable to use provisioner with vsphere provider.
We cannot use remote-exec provisioner with vsphere provider for now, because vsphere provider doesn't provide host to provisioner connections. And the debug log is following:

(remote-exec): Connecting to remote host via SSH...
(remote-exec):   Host: 
(remote-exec):   User: root
(remote-exec):   Password: true
(remote-exec):   Private key: false
(remote-exec):   SSH Agent: false

Workaround:

proivsioner "remote-exec" {
  scripts = {
    "aaa.sh"
  }
  connections = {
    user = "${var.ssh_user}"
    password = "${var.ssh_password}"
    host = "${self.network_interface.0.ipv4_address}"
}

[phinze]

It looks like this will call d.SetConnInfo only when the waitForNetworkingActive code path is not executed. Is this the desired behavior? Seems like we might want to SetConnInfo after the boot waiting as well?

[higebu]

That's right! I'll fix it soon!

[higebu]

@phinze I fixed the behavior and rebased to master branch.

[rossedman]

👍 This has been driving me crazy. Glad I stumbled across this. Would love to see this get implemented. Have to roll this out across some big datacenters and would like to now use work arounds. Great work.

[phinze]

This LGTM - still working on getting a vSphere environment on our side to be able to properly test these PRs, but in the meantime this looks like a pretty straightforward win. 👍

[higebu]

Thank you!

[rossedman]

@phinze I have vSphere 6 at home. Let me know if you need some help.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.