Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fixes the use of Uppercase chars in ELB Listeners #5376

Merged
merged 1 commit into from
Mar 9, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 29, 2016

Fixes #5303 - where the usage of uppercase characters in https / ssl listener said the listener was added when it wasn't. This PR doesn't change the behviour at all - it just changes how we check that we are creating a valid ELB listener config

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSELB' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSELB -timeout 120m
=== RUN   TestAccAWSELB_basic
--- PASS: TestAccAWSELB_basic (30.14s)
=== RUN   TestAccAWSELB_fullCharacterRange
--- PASS: TestAccAWSELB_fullCharacterRange (25.72s)
=== RUN   TestAccAWSELB_AccessLogs
--- PASS: TestAccAWSELB_AccessLogs (74.76s)
=== RUN   TestAccAWSELB_generatedName
--- PASS: TestAccAWSELB_generatedName (22.79s)
=== RUN   TestAccAWSELB_availabilityZones
--- PASS: TestAccAWSELB_availabilityZones (39.87s)
=== RUN   TestAccAWSELB_tags
--- PASS: TestAccAWSELB_tags (42.28s)
=== RUN   TestAccAWSELB_iam_server_cert
--- PASS: TestAccAWSELB_iam_server_cert (33.54s)
=== RUN   TestAccAWSELB_InstanceAttaching
--- PASS: TestAccAWSELB_InstanceAttaching (142.16s)
=== RUN   TestAccAWSELBUpdate_Listener
--- PASS: TestAccAWSELBUpdate_Listener (51.82s)
=== RUN   TestAccAWSELB_HealthCheck
--- PASS: TestAccAWSELB_HealthCheck (26.24s)
=== RUN   TestAccAWSELBUpdate_HealthCheck
--- PASS: TestAccAWSELBUpdate_HealthCheck (50.48s)
=== RUN   TestAccAWSELB_Timeout
--- PASS: TestAccAWSELB_Timeout (38.09s)
=== RUN   TestAccAWSELBUpdate_Timeout
--- PASS: TestAccAWSELBUpdate_Timeout (56.80s)
=== RUN   TestAccAWSELB_ConnectionDraining
--- PASS: TestAccAWSELB_ConnectionDraining (30.56s)
=== RUN   TestAccAWSELBUpdate_ConnectionDraining
--- PASS: TestAccAWSELBUpdate_ConnectionDraining (69.16s)
=== RUN   TestAccAWSELB_SecurityGroups
--- PASS: TestAccAWSELB_SecurityGroups (55.63s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    790.071s

@jen20
Copy link
Contributor

jen20 commented Mar 9, 2016

LGTM!

jen20 added a commit that referenced this pull request Mar 9, 2016
provider/aws: Fixes the use of Uppercase chars in ELB Listeners
@jen20 jen20 merged commit 7436cf7 into hashicorp:master Mar 9, 2016
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ELB Listener fails silently when setting lb_protocol to "SSL" instead of "ssl"
2 participants