core: output "diffs didn't match" error details #5276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these details were relegated to the debug logs, which forces the user to reproduce the error condition and then go digging for the error message. Since we're asking users to report this error, let's give them all the details they need right up front to make it a little easier on them.
phinze
force-pushed
the
phinze/diffs-didnt-matchs-output
branch
from
fb5f715
to
78f5780
Compare
|
LOVE THIS! This is the basis of a github issue within the code :) |
phinze
added a commit
that referenced
this pull request
Feb 23, 2016
core: output "diffs didn't match" error details
|
We should also include this in crash dumps? |
|
@jen20 We do have a message that shows on panics. Probably could use a bit of improvement - any ideas? |
|
Additional formatting tweak here b831ba3 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these details were relegated to the debug logs, which forces
the user to reproduce the error condition and then go digging for the
error message. Since we're asking users to report this error, let's give
them all the details they need right up front to make it a little easier
on them.