Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Implement RetentionPeriod Changes for Kinesis Stream #5223

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 19, 2016

As requested in #5219

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSKinesisStream' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run=TestAccAWSKinesisStream -timeout 120m
=== RUN   TestAccAWSKinesisStream_basic
--- PASS: TestAccAWSKinesisStream_basic (93.62s)
=== RUN   TestAccAWSKinesisStream_retentionPeriod
--- PASS: TestAccAWSKinesisStream_retentionPeriod (179.95s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    273.587s

@stack72 stack72 changed the title [WIP] Implement RetentionPeriod Changes for AWS Kinesis Stream [WIP] provider/aws: Implement RetentionPeriod Changes for Kinesis Stream Feb 19, 2016
@stack72 stack72 force-pushed the f-aws-kinesis-retention-period branch from c9987f2 to c6e2043 Compare February 23, 2016 10:35
@stack72 stack72 changed the title [WIP] provider/aws: Implement RetentionPeriod Changes for Kinesis Stream provider/aws: Implement RetentionPeriod Changes for Kinesis Stream Feb 23, 2016

} else {
log.Printf("[DEBUG] Kinesis Stream (%q) Retention Period Not Changed", sn)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could rearrange this to make it a bit shorter and simpler:

if n == o {
  // log & return
}
if n > o {
  // increase
} else {
  // decrease
}
// waitforstate here, same for both

@phinze
Copy link
Contributor

phinze commented Feb 23, 2016

LGTM generally - one small suggestion inline

@stack72 stack72 force-pushed the f-aws-kinesis-retention-period branch from c6e2043 to 8d6cfe8 Compare February 23, 2016 17:15
stack72 added a commit that referenced this pull request Feb 23, 2016
provider/aws: Implement RetentionPeriod Changes for Kinesis Stream
@stack72 stack72 merged commit 039065f into hashicorp:master Feb 23, 2016
@stack72 stack72 deleted the f-aws-kinesis-retention-period branch February 23, 2016 17:27
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants