Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the deployment configuration settings to the ecs service resource #5220

Merged
merged 1 commit into from
Feb 21, 2016

Conversation

joshgarnett
Copy link

This resolves issue #4456

@stack72
Copy link
Contributor

stack72 commented Feb 21, 2016

Thanks for the PR @joshgarnett - I have just ran the tests locally (and added a specific test for this) - all look ok:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsService' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsService -timeout 120m
=== RUN   TestAccAWSEcsServiceWithARN
--- PASS: TestAccAWSEcsServiceWithARN (30.50s)
=== RUN   TestAccAWSEcsServiceWithFamilyAndRevision
--- PASS: TestAccAWSEcsServiceWithFamilyAndRevision (122.17s)
=== RUN   TestAccAWSEcsServiceWithRenamedCluster
--- PASS: TestAccAWSEcsServiceWithRenamedCluster (228.92s)
=== RUN   TestAccAWSEcsService_withIamRole
--- PASS: TestAccAWSEcsService_withIamRole (40.53s)
=== RUN   TestAccAWSEcsService_withDeploymentValues
--- PASS: TestAccAWSEcsService_withDeploymentValues (29.91s)
=== RUN   TestAccAWSEcsService_withLbChanges
--- PASS: TestAccAWSEcsService_withLbChanges (72.50s)
=== RUN   TestAccAWSEcsService_withEcsClusterName
--- PASS: TestAccAWSEcsService_withEcsClusterName (38.46s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    563.002s

@stack72 stack72 closed this Feb 21, 2016
@stack72 stack72 reopened this Feb 21, 2016
@stack72 stack72 closed this Feb 21, 2016
@stack72 stack72 merged commit 12958fb into hashicorp:master Feb 21, 2016
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants