Bypass CreateBeforeDestroyTransformer on terraform destroy #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vancluever
force-pushed
the
paybyphone_create_before_destroy_bypass
branch
from
763534e
to
4a22ac5
Compare
|
👍 |
1 similar comment
|
👍 |
|
@catsby does this look good to you guys? |
|
@phinze We're also running into this issue and would love to see this fix (or something similar) be included in the next terraform release. |
|
LGTM - I have another full-stack test I just wrote to exercise this that I'll add on master and link back here. |
phinze
added a commit
that referenced
this pull request
Feb 23, 2016
…troy_bypass Bypass CreateBeforeDestroyTransformer on terraform destroy
phinze
added a commit
that referenced
this pull request
Feb 23, 2016
|
@phinze Awesome! Looking forward to this being released! ❤️ |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #3294, #2493, #2359, possibly others.
This patch ensures that create_before_destroy is ignored during a
terraform destroyoperation by ensuring its graph transformer does not get added at all. IfDestroyis true (ultimately passed in through context), it just gets skipped.This ensures that this is not even considered during a destroy operation (where destroying resources is the only thing that makes sense), versus a replacement operation (where if you have specified
create_before_destroy, you obviously want it).Also, I have included a couple of simple tests that ensures the presence/non-presence of the transformer appropriately.