providers/google: add external_address; needed for connection #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. While you're at it, you may want to also have |
|
Also, hey Isaac! :) |
|
Hey Mitchell! |
|
|
||
| // resourceInstanceNatIP acquires the first NatIP with a "ONE_TO_ONE_NAT" type | ||
| // in the compute.NetworkInterface's AccessConfigs. | ||
| func resourceInstanceNatIP(iface *compute.NetworkInterface) (natIP string) { |
There was a problem hiding this comment.
named return values are ALMOST never used, don't think this is a good place to use it. But, I'll fix that style nitpick when I merge. :)
|
LGTM. Thanks! |
mitchellh
added a commit
that referenced
this pull request
Oct 21, 2014
providers/google: add external_address; needed for connection
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the external IP for Google instances.