provider/docker: Add support of custom networks #4483
Conversation
|
The networks can't be used from terraform quite yet as the connect and disconnect API haven't been implemented in fsouza/go-dockerclient ( fsouza/go-dockerclient#442 ) |
|
Upstream issue fixed, I added a commit to the pull request. |
|
Thanks @ColinHebert - I'll rerun the build on Travis now the upstream has merged. |
|
@ColinHebert - looks like there are legit build failures: https://travis-ci.org/hashicorp/terraform/builds/100197037#L517 |
|
@jen20 yep they're fixed now. |
|
Hi @ColinHebert! I fixed up a merge conflict here and merged this manually. As part of it I fixed up the image tests so that they don't depend on a hash which changes. Thanks for your contribution, and sorry this took us so long to get to. |
|
Hey no worries @jen20, thanks for merging that :) |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #4478