Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: IAM Role now Allows Update Assume Policy Document #4107

Merged
merged 1 commit into from
Nov 30, 2015
Merged

provider/aws: IAM Role now Allows Update Assume Policy Document #4107

merged 1 commit into from
Nov 30, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 30, 2015

Changing the IAM Role resource to allow update of Assume Policy Document

Fixes #3106 - tests all still pass:

make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSRole_' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSRole_ -timeout 90m
=== RUN   TestAccAWSRole_basic
--- PASS: TestAccAWSRole_basic (5.14s)
=== RUN   TestAccAWSRole_testNameChange
--- PASS: TestAccAWSRole_testNameChange (11.58s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    16.735s

jen20
jen20 reviewed Nov 30, 2015
View reviewed changes
builtin/providers/aws/resource_aws_iam_role.go
}
_, err := iamconn.UpdateAssumeRolePolicy(assumeRolePolicyInput)
if err != nil {
if iamerr, ok := err.(awserr.Error); ok && iamerr.Code() == "NoSuchEntity" { // XXX test me
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the XXX test me referring to here?

@jen20
Copy link
Contributor

jen20 commented Nov 30, 2015

Thanks @stack72, this looks good. I left one question in line on the diff to clarify before merging.

@stack72 stack72 force-pushed the f-aws-iam_role_assume_policy_doc_update branch from 245951c to fece57f Compare November 30, 2015 12:52
@jen20
Copy link
Contributor

jen20 commented Nov 30, 2015

👍 this looks good! Thanks @stack72!

jen20 added a commit that referenced this pull request Nov 30, 2015
@jen20
Merge pull request #4107 from stack72/f-aws-iam_role_assume_policy_do…
683989f 
…c_update

provider/aws: IAM Role now Allows Update Assume Policy Document
@jen20 jen20 merged commit 683989f into hashicorp:master Nov 30, 2015
@stack72 stack72 deleted the f-aws-iam_role_assume_policy_doc_update branch November 30, 2015 12:59
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_iam_role changing assume_role_policy forces new role to be created, should just update
2 participants
@stack72 @jen20