provider/openstack: Add fixed ips to openstack ports

[Fodoj]

No description provided.

[jtopjian]

Thank you very much for this! I don't use ports, so the initial commit was going off of assumptions and devstack. Perfect timing so it gets cleaned up for the next release.

I'll review all commits in detail later today.

[jtopjian]

Everything else looks good!

I made the appropriate changes to the subnets locally and the tests pass, so it's good to go after that. I'll commit once you take care of that.

Great addition - thank you!

[Fodoj]

@jtopjian do you mean ${openstack_networking_subnet_v2.foo.id} change? Is that enough to fix tests?

[jtopjian]

Yeah, for the modification in resource_openstack_networking_network_v2_tests.go and in the documentation, that's all.

For resource_openstack_networking_port_v2_tests.go, a few changes are needed:

1. Import the subnet package
2. Declare a subnet variable
3. Add a subnet block to the test
4. Change the hard-coded subnet ID to a variable reference
5. Add a testAccCheckNetworkingV2SubnetExists alongside the other resources in that test.

Let me know if you need a hand 😄

[Fodoj]

@jtopjian thanks for your review! Changes to tests are pushed.

[jtopjian]

Looks good!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.