Fix ValidateAccountId for IAM Instance Profiles #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @phinze or @radeksimko - can we get a merge here? This change is trivial, and fixes an important use-case for us. |
|
@bobtfish thanks for the ping! this looks good. working my way up through the stack, but this seems reasonable to do now. 👍 |
phinze
added a commit
that referenced
this pull request
Oct 7, 2015
Fix ValidateAccountId for IAM Instance Profiles
|
It may help us to get rid of the crash, but it's not solving the original problem... See the discussion here: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently while running terraform plan against IAM instance profiles terraform crashes . It was throwing an exception and exiting on 0.6.3 and prior but #3001 missed to exit out of the function . This PR fixes that . Testing this version on IAM instance profiles, no more crashes terraform and throws up exception but works as expected.