aws: store and read instance state

[fatih]

This allows us to store the instance state into the state file. This
means we can now easily see the instance state with terraform show.

An example terraform show result:

[radeksimko]

What do you think of making this field (with some extra logic) not just Computed, but also Optional? The default option would be running and other possible option stopped, which can solve #1579 😉

[stack72]

I love that idea - we have 1 or 2 instance resources that when i rerun TF, they create running instances. I'd love to be able to mark them as stopped :)

[fatih]

Hi @radeksimko

This sounds good. I'm curious about how the flow should be. Assume I have a tf file which creates two aws instances of type t2.micro. They are in running state. I'll stop them manually, which means they are in stopping state.

Now if I run terraform apply, it reads the state file, (probably also refresh the resources) and start them again, so the final state of the instances are again running? Is this correct?

[radeksimko]

@fatih Yes, the described flow is exactly how I think it should work. Expected state by default should be running.

EC2.StopInstances and EC2.StartInstances may be useful.

[fatih]

Thanks for the clarification @radeksimko. I'll work on the rest and update the PR. I'll ping again once I'm ready.

[catsby]

Hey all – is this still a work in progress, or shall we close it?

[fatih]

@catsby unfortunately I don't have time to tackle the idea of @radeksimko beyond this current PR. Feel free to close, or merge and work on a different PR if you wish.

[catsby]

Thanks for the update @fatih ! We'll review and see if it's something we can pick up on. Appreciate what you've done so far 😄

[catsby]

Going to merge as is, thank you!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.