Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging to cloudstack provider #3175

Closed
glenjamin opened this issue Sep 6, 2015 · 6 comments
Closed

Add debug logging to cloudstack provider #3175

glenjamin opened this issue Sep 6, 2015 · 6 comments

Comments

@glenjamin
Copy link
Contributor

I'm happy to provide a PR for this, I wanted to check on the general policy for debug logging first.

At the moment it can be a little tricky to debug cloudstack failures, as there's nothing in the logs to show which API was called, and with what parameters.

I can see two options here to improve this story

  1. Add debug logging capabilities into go-cloudstack, based on an environment variable
  2. Add debug logging next to every go-cloudstack api call in the terraform profider, which would respect TF_LOG

The latter would probably be simpler, as it it doesn't require a new way of enabling debug logging. Is there a general policy for what should or shouldn't be included in the TF_LOG output?

@svanharmelen
Copy link
Contributor

@phinze I don't think there is a policy for this right? As long as common sense is used, it should be fine IMHO...

@phinze
Copy link
Contributor

phinze commented Sep 28, 2015

Agreed! @glenjamin you can just go ahead with (2) and add debug logging to the provider.

@svanharmelen
Copy link
Contributor

@glenjamin are you ok with me closing this one? Think your question is answered and your good to go write some logging right?

Also please keep an eye on PR #3380 as it seems that one will be merged shortly and it improves/extends the logging capabilities if TF.

@glenjamin
Copy link
Contributor Author

It's vaguely on my todo, might be better off keeping it open in case someone else wants to pick it up?

@svanharmelen
Copy link
Contributor

Well in that case I'll go ahead and close it off... 😉 With well over 500 open issues I don't think it adds much value to leave this one open as well. Especially since the question in the issue is answered and can be found back by others when searching through the issues.

Thanks!

@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants