Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add support for IAM SAML provider #3156

Merged
merged 3 commits into from
Oct 4, 2015
Merged

provider/aws: Add support for IAM SAML provider #3156

merged 3 commits into from
Oct 4, 2015

Conversation

radeksimko
Copy link
Member

Test plan

$ make testacc TEST=./builtin/providers/aws TESTARGS="-run=IAMSamlProvider" 2>/dev/null

go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=IAMSamlProvider -timeout 90m
=== RUN   TestAccAWSIAMSamlProvider_basic
--- PASS: TestAccAWSIAMSamlProvider_basic (4.45s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    4.465s

@apparentlymart
Copy link
Contributor

👍 LGTM. This one seems pretty straightforward, for a change. 😁

@apparentlymart apparentlymart merged commit 5d215c4 into hashicorp:master Oct 4, 2015
apparentlymart added a commit that referenced this pull request Oct 4, 2015
@apparentlymart
Merge #3156: aws_iam_saml_provider resource
b8706a2
@radeksimko radeksimko deleted the f-aws-iam-saml branch October 4, 2015 01:21
bmcustodio pushed a commit to bmcustodio/terraform that referenced this pull request Sep 26, 2017
@sethvargo @vishalnayak
Rename database plugins for SEO (hashicorp#3156)
3d5522f 
When we "nest" like this, it's important to use a common suffix,
"Database Secret Backend" in this case, so that the SEO minions can
properly group search results for end users.
@ghost
Copy link

ghost commented Apr 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @apparentlymart