Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: allow external ENI attachments #2943

Merged
merged 1 commit into from
Aug 5, 2015

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Aug 5, 2015

If Terraform creates an ENI and it's attached out of band, Terraform
should not attempt to remove the attachment on subsequent runs.

fixes #2436
fixes #2881

If Terraform creates an ENI and it's attached out of band, Terraform
should not attempt to remove the attachment on subsequent runs.

fixes #2436
fixes #2881
@phinze phinze force-pushed the b-allow-external-eni-attachments branch from c3ae67e to 3de3002 Compare August 5, 2015 16:07
@catsby
Copy link
Contributor

catsby commented Aug 5, 2015

LGTM 👍

@phinze phinze merged commit fd10ceb into master Aug 5, 2015
@phinze phinze deleted the b-allow-external-eni-attachments branch August 5, 2015 16:14
@stack72
Copy link
Contributor

stack72 commented Aug 5, 2015

Thanks for this @phinze :)

@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS network_interface detaches instances Support ignoring whether or not an ENI is attached to an instance
3 participants