-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Add resource IDs to apply-errors + prevent error duplication #2815
core: Add resource IDs to apply-errors + prevent error duplication #2815
Conversation
In fact it's not fixing #2801 (yet) since it's just addressing |
Ok, same approach for refresh applied, now I need your votes/opinion about reporting via UiHook or aggregating errors and printing at the end. I'm slightly more inclined to hooks, but both solutions have different pros/cons. |
7b4a67b
to
a22dc2a
Compare
I only tested this with the Route 53 example from 2801, but overall 👍 to this idea. The change seems small enough, but word from @mitchellh or @phinze may be prudent |
This is nice! LGTM |
So you both prefer error aggregation over real-time errors then? |
Ah thanks for pointing that out - I had overlooked the impl question. I think getting resource IDs into the error message is an important enough win that it's better to land this as-is and we can always circle back if we find that waiting for the errors to output becomes annoying. 👍 |
@phinze Agreed, it can be revisited later. |
core: Add resource IDs to apply-errors + prevent error duplication
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This is a proposal for fixing #2801 and similar with a more systematic approach.
Current state:
this PR is changing it into the following (no duplicate errors and resource ID mentioned):
Here's a simple way to trigger an error (and see the difference):
git blame command/hook_ui.go
only brought up @mitchellh , so I think he would be the best candidate for reviewing.The other option would be to keep the error printing in UiHook which has the advantage of more "real-time" feedback, but in that case we should:
eval_apply.go
so it's not duplicated.FYI @failshell @catsby