provider/docker: Fix Repository in PullOptions

[Nomon]

0558763 breaks pulling images from private registries. The docker api client/daemon expects the whole image name including the registry as Repository attribute in pull options (as in "private.registry.com:port/image" as the image name not just "image"). Currently if you do a docker_image resource with name = "private.registry.com:port/image:tag" it will create the following pulloptions:

&PullOptions{
  Registry: "private.registry.com:port",
  Tag: "tag",
  Repository: "image"
}

This tries to pull image called library/image:tag from default docker registry and the pull will fail with error message:
Unable to read Docker image into resource: Unable to pull image private.registry.com:port/image:tag: Error pulling image private.registry.com:port/image:tag: Error: image library/image:tag not found.

The correct pull options would be (and what the previous version of pullImage did):

&PullOptions{
  Registry: "private.registry.com:port",
  Tag: "tag",
  Repository: "private.registry.com:port/image"
}

I created an acceptance test that does not pass without this change against google docker registry. Tested against docker 1.7.

[ghost]

Seeing this issue in Terraform v0.6.3.

[josephholsten]

@phinze 👀, has a test

[phinze]

Sorry for the delay on this - @rvm2015 - looks great! Thank you! 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.