core: Change string list representation so we can distinguish empty, single element lists #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial pure "all tests passing without a diff" stage. The plan is to change the internal representation of StringList to include a suffix delimiter, which will allow us to recognize empty and single-element lists.
Now the only code that cares about how StringLists are represented lives inside string_list.go ...which gives us the ability to change it! :)
Had to handle a lot of implicit leaning on a few properties of the old representation: * Old representation allowed plain strings to be treated as lists without problem (i.e. shoved into strings.Split), now strings need to be checked whether they are a list before they are treated as one (i.e. shoved into StringList(s).Slice()). * Tested behavior of 0 and 1 length lists in formatlist() was a side effect of the representation. Needs to be special cased now to maintain the behavior. * Found a pretty old context test failure that was wrong in several different ways. It's covered by TestContext2Apply_multiVar so I removed it.
removes treat-lists-as-scalar special casing for formatlist /cc @radeksimko fixes #2240
| } | ||
|
|
||
| finalList = append(finalList, argument) |
There was a problem hiding this comment.
This was implicitly relying on the fact that the old representation of StringLists allowed them to be arbitrarily combined with bare elements.
For example, previously: ["foo", "barSLDbaz", "qux"] would make it through the strings.Join as a valid list. Now we need to respect the encapsulation of the type and handle it explicitly.
phinze
changed the title
|
Surprisingly simple. LGTM! |
phinze
added a commit
that referenced
this pull request
Jun 26, 2015
core: Change string list representation so we can distinguish empty, single element lists
4 tasks
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encapsulates and enhances the internal representation of lists within terraform's core.
To work around limitations of the current architecture, lists need to be "flattened" into a string as they're passed around the config interpolation.
Given a list
["foo", "bar", "baz"], the previous format for these strings was:foo(special delimiter)bar(special delimiter)baz.This format made it impossible to distinguish between:
["foo"]and"foo"[]and""[""]and""Here's the new way we use the "string list delimiter" (SLD) as described in a comment: