Improve ssh connection debug messages #22097
Conversation
|
|
communicator/ssh/communicator.go
Outdated
| if err != nil { | ||
| err = errors.New(fmt.Sprintf("ssh %s@%s: %s", c.connInfo.User, hostAndPort, err)) |
There was a problem hiding this comment.
Thank you for improving all the debug messages - these look 👍 to me.
How do you feel about using https://github.com/hashicorp/errwrap for wrapping the error here, so we're not just turning the error into a string, but retaining all useful details?
e.g.
errwrap.Wrapf(fmt.Sprintf("Failed to establish SSH connection (%s@%s): {{err}}", c.connInfo.User, hostAndPort), err)There was a problem hiding this comment.
I was wondering if there was a better way. I'll make that change.
radeksimko
added
the
waiting-response
1) Mention the host and port in the "Connecting..." message. 2) Mention the username in the post-connection handshaking message. 3) If handshaking fails, mention the user, host, and port in the error message that will eventually be returned to the user.
radeksimko
removed
the
waiting-response
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Mention the host and port in the "Connecting..." message.
Mention the username in the post-connection handshaking message.
If handshaking fails, mention the user, host, and port in the error
message that will eventually be returned to the user.