core: respect roots in CBD transform #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // If the graph has a "root" node (one added by a RootTransformer and not | ||
| // just a resource that happens to have no ancestors), we don't want to | ||
| // add any edges to it, because then it ceases to be a root. |
There was a problem hiding this comment.
Ah this makes a lot of sense. We now do a root transformer potentially before the destroy transform which never happened before. I see how this happened.
|
LGTM |
Because CBD now runs after a RootTransformer, it's now operating on a graph that _may_ have had a graphNodeRoot added to it (a noop node whose only purpose is to be a root). CBD includes a step that tells the destroy node to depend on any parents of the create node. When one of those parents was "root", this was causing the destroy node to depend on "root", making it cease to be an actual root node. Because graphNodeRoot is a singleton, the follow-up RootTransformer was not sufficient to slap another root on top - it wasn't being seen as a fresh node, so edges were just accumulating, and we ended up in a state with "no roots". refs #1903 (not sure if this will fix all the "no root found" cases, or just the one I bumped into)
phinze
added a commit
that referenced
this pull request
May 13, 2015
core: respect roots in CBD transform
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1903
Details in code comment.