Closes #1908. Parse AccountId from User ARN for RDS tags

[johnrengelman]

Based on: https://github.com/hashicorp/terraform/pull/1803/files#diff-047ff2782c4a593ae27a5b9bd8ad998fR289

[mitchellh]

LGTM

[catsby]

Looks good! As I noted in #1908 , I'm curious why it worked for me in the past. IAM cred issue perhaps?

This could also be a good time to test the tags in AWS RDS instance, by tacking on a test to TestAccAWSDBInstance. Is that something you want to try out? Similar to https://github.com/hashicorp/terraform/blob/master/builtin/providers/aws/resource_aws_instance_test.go#L339, though you'd probably need an RDS specific implementation of testAccCheckTagsSDK.

I can do so later if you don't think you'll have time.

Thanks again!

[catsby]

I created a DB with this config:

provider "aws" {
  region = "us-west-2"
}

resource "aws_db_instance" "bar" {
    identifier = "foobarbaz-test-terraform-test2"

    allocated_storage = 5
    engine = "mysql"
    engine_version = "5.6.21"
    instance_class = "db.t1.micro"
    name = "baz"
    password = "barbarbarbar"
    username = "foo"

    backup_retention_period = 0

  tags {
    One = "Two"
    Three = "Four"
  }

    parameter_group_name = "default.mysql5.6"
}

Creation went fine, I then tried to remove the tag Three :

~ aws_db_instance.bar
    tags.#:     "2" => "1"
    tags.Three: "Four" => ""

Applying that gave me an error:

* Error modifying DB Instance foobarbaz-test-terraform-test2: InvalidParameterCombination: No modifications were requested

I'll re-run the scenario on master but as you know, RDS takes time... 😄

Note: I'm not using IAM

[johnrengelman]

What you've just encountered is another bug: #1906

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.