Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/alicloud: Add the function of replacing ecs instance's system disk #15048

Merged
merged 2 commits into from
Jun 5, 2017

Conversation

xiaozhu36
Copy link
Contributor

This PR adds a function that can replace system disk for an existing ecs instance. And while replacing system disk, it can chang system disk size.

Run the PR's testcase result as follows:

TF_ACC=1 go test ./alicloud -v -run=TestAccAlicloudInstance -timeout 120m
=== RUN TestAccAlicloudInstanceTypesDataSource_basic
--- PASS: TestAccAlicloudInstanceTypesDataSource_basic (14.70s)
=== RUN TestAccAlicloudInstance_basic
--- PASS: TestAccAlicloudInstance_basic (104.20s)
=== RUN TestAccAlicloudInstance_vpc
--- PASS: TestAccAlicloudInstance_vpc (112.01s)
=== RUN TestAccAlicloudInstance_userData
--- PASS: TestAccAlicloudInstance_userData (125.50s)
=== RUN TestAccAlicloudInstance_multipleRegions
--- PASS: TestAccAlicloudInstance_multipleRegions (342.78s)
=== RUN TestAccAlicloudInstance_multiSecurityGroup
--- PASS: TestAccAlicloudInstance_multiSecurityGroup (3.44s)
=== RUN TestAccAlicloudInstance_multiSecurityGroupByCount
--- PASS: TestAccAlicloudInstance_multiSecurityGroupByCount (3.72s)
=== RUN TestAccAlicloudInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAlicloudInstance_NetworkInstanceSecurityGroups (107.63s)
=== RUN TestAccAlicloudInstance_tags
--- PASS: TestAccAlicloudInstance_tags (91.18s)
=== RUN TestAccAlicloudInstance_update
--- PASS: TestAccAlicloudInstance_update (87.35s)
=== RUN TestAccAlicloudInstanceImage_update
--- PASS: TestAccAlicloudInstanceImage_update (212.84s)
=== RUN TestAccAlicloudInstance_privateIP
--- PASS: TestAccAlicloudInstance_privateIP (99.39s)
=== RUN TestAccAlicloudInstance_associatePublicIP
--- PASS: TestAccAlicloudInstance_associatePublicIP (113.35s)
=== RUN TestAccAlicloudInstance_vpcRule
--- PASS: TestAccAlicloudInstance_vpcRule (118.18s)
PASS
ok github.com/alibaba/terraform-provider/alicloud 118.200s

@stack72
Copy link
Contributor

stack72 commented Jun 5, 2017

This LGTM! Thanks for this :)

% make testacc TEST=./builtin/providers/alicloud TESTARGS='-run=TestAccAlicloudInstance'                                                     ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/05 00:11:02 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/alicloud -v -run=TestAccAlicloudInstance -timeout 120m
=== RUN   TestAccAlicloudInstanceTypesDataSource_basic
--- PASS: TestAccAlicloudInstanceTypesDataSource_basic (202.13s)
=== RUN   TestAccAlicloudInstance_basic
--- PASS: TestAccAlicloudInstance_basic (335.21s)
=== RUN   TestAccAlicloudInstance_vpc
--- PASS: TestAccAlicloudInstance_vpc (328.67s)
=== RUN   TestAccAlicloudInstance_userData
--- PASS: TestAccAlicloudInstance_userData (346.38s)
=== RUN   TestAccAlicloudInstance_multipleRegions
--- PASS: TestAccAlicloudInstance_multipleRegions (286.93s)
=== RUN   TestAccAlicloudInstance_multiSecurityGroup
--- PASS: TestAccAlicloudInstance_multiSecurityGroup (631.92s)
=== RUN   TestAccAlicloudInstance_multiSecurityGroupByCount
--- PASS: TestAccAlicloudInstance_multiSecurityGroupByCount (276.32s)
=== RUN   TestAccAlicloudInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAlicloudInstance_NetworkInstanceSecurityGroups (297.05s)
=== RUN   TestAccAlicloudInstance_tags
--- PASS: TestAccAlicloudInstance_tags (318.00s)
=== RUN   TestAccAlicloudInstance_update
--- PASS: TestAccAlicloudInstance_update (273.76s)
=== RUN   TestAccAlicloudInstance_privateIP
--- PASS: TestAccAlicloudInstance_privateIP (362.18s)
=== RUN   TestAccAlicloudInstance_associatePublicIP
--- PASS: TestAccAlicloudInstance_associatePublicIP (407.83s)
=== RUN   TestAccAlicloudInstance_vpcRule
--- PASS: TestAccAlicloudInstance_vpcRule (437.96s)
PASS
ok	github.com/hashicorp/terraform/builtin/providers/alicloud	4648.547s

@stack72 stack72 merged commit 87562be into hashicorp:master Jun 5, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants