provider/heroku: Add resources for Heroku Pipelines

[justincampbell]

Adds 2 resources: heroku_pipeline and heroku_pipeline_coupling to allow managing Heroku Pipelines with Terraform.

Example Terraform config:

resource "heroku_pipeline" "default" {
  name = "my-pipeline"
}

resource "heroku_app" "alpha" {
  name   = "justincampbell-test-alpha"
  region = "us"
}

resource "heroku_pipeline_coupling" "alpha" {
  app      = "${heroku_app.alpha.id}"
  pipeline = "${heroku_pipeline.default.id}"
  stage    = "development"
}

resource "heroku_app" "beta" {
  name   = "justincampbell-test-beta"
  region = "us"
}

resource "heroku_pipeline_coupling" "beta" {
  app      = "${heroku_app.beta.id}"
  pipeline = "${heroku_pipeline.default.id}"
  stage    = "staging"
}

resource "heroku_app" "release" {
  name   = "justincampbell-test-release"
  region = "us"
}

resource "heroku_pipeline_coupling" "release" {
  app      = "${heroku_app.release.id}"
  pipeline = "${heroku_pipeline.default.id}"
  stage    = "production"
}

Acceptance test output:

$ clear; make testacc TEST=./builtin/providers/heroku TESTARGS="-run Pipeline"
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/28 16:16:16 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/heroku -v -run Pipeline -timeout 120m
=== RUN   TestAccHerokuPipelineCoupling_Basic
--- PASS: TestAccHerokuPipelineCoupling_Basic (4.58s)
=== RUN   TestAccHerokuPipeline_Basic
--- PASS: TestAccHerokuPipeline_Basic (2.92s)
=== RUN   TestPipelineStage
--- PASS: TestPipelineStage (0.00s)

[grubernaut]

LGTM, few very minor nits. Thanks!

[grubernaut]

Since this is a required attribute, can initialize the PipelineCreateOpts struct with the Name field populated:

opts := heroku.PipelineCreateOpts{
  Name: d.Get("name").(string),
}

[grubernaut]

Same as above, as these are all required parameters

[grubernaut]

Could output the difference in ID's here for clarity

[grubernaut]

Why the extra argument here?

[grubernaut]

should scope this to the validator function

[justincampbell]

Thanks @grubernaut! I addressed each of the comments above.

[grubernaut]

LGTM, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.