Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/azurerm: support import for load balancer and sub resources #11610

Merged
merged 1 commit into from
Feb 1, 2017
Merged

provider/azurerm: support import for load balancer and sub resources #11610

merged 1 commit into from
Feb 1, 2017

Conversation

pmcatominey
Copy link
Contributor

  • implemented ResourceImporter for sub resources which extracts the lb id
  • deprecated location on each sub resource as it was unused

Ran all LB tests including new import tests:

TestAccAzureRMLoadBalancer_importBasic
TestAccAzureRMLoadBalancerNatPool_importBasic
TestAccAzureRMLoadBalancerNatPool_removal
TestAccAzureRMLoadBalancerBackEndAddressPool_basic
TestAccAzureRMLoadBalancerBackEndAddressPool_removal
TestAccAzureRMLoadBalancerNatRule_importBasic
TestAccAzureRMLoadBalancerNatPool_basic
TestAccAzureRMLoadBalancerProbe_importBasic
TestAccAzureRMLoadBalancerBackEndAddressPool_disappears
TestAccAzureRMLoadBalancerBackEndAddressPool_importBasic
TestAccAzureRMLoadBalancerRule_importBasic
TestAccAzureRMLoadBalancerBackEndAddressPool_reapply
TestAccAzureRMLoadBalancerNatPool_update
TestAccAzureRMLoadBalancerNatPool_disappears
TestAccAzureRMLoadBalancerNatRule_basic
TestAccAzureRMLoadBalancerProbe_removal
TestAccAzureRMLoadBalancerNatPool_reapply
TestAccAzureRMLoadBalancerProbe_update
TestAccAzureRMLoadBalancerNatRule_disappears
TestAccAzureRMLoadBalancerNatRule_removal
TestAccAzureRMLoadBalancerProbe_basic
TestAccAzureRMLoadBalancerNatRule_reapply
TestAccAzureRMLoadBalancerNatRule_update
TestAccAzureRMLoadBalancerProbe_updateProtocol
TestAccAzureRMLoadBalancer_basic
TestAccAzureRMLoadBalancer_tags
TestAccAzureRMLoadBalancerProbe_reapply
TestAccAzureRMLoadBalancerRule_removal
TestAccAzureRMLoadBalancerProbe_disappears
TestAccAzureRMLoadBalancerRule_basic
TestAccAzureRMLoadBalancerRule_inconsistentReads
TestAccAzureRMLoadBalancerRule_disappears
TestAccAzureRMLoadBalancerRule_update
TestAccAzureRMLoadBalancerRule_reapply
TestAccAzureRMLoadBalancer_frontEndConfig

provider/azurerm: support import for load balancer and sub resources
183b117 
implemented ResourceImporter for sub resources which extracts the lb id
deprecated location on each sub resource as it was unused
@stack72
Copy link
Contributor

stack72 commented Feb 1, 2017

This is great work! LGTM!

@stack72 stack72 merged commit bbde053 into hashicorp:master Feb 1, 2017
stack72 pushed a commit that referenced this pull request Feb 1, 2017
@pmcatominey @stack72
provider/azurerm: support import for load balancer and sub resources (#…
9d85674 
…11610)

implemented ResourceImporter for sub resources which extracts the lb id
deprecated location on each sub resource as it was unused
arcadiatea pushed a commit to ticketmaster/terraform that referenced this pull request Feb 9, 2017
@pmcatominey @arcadiatea
provider/azurerm: support import for load balancer and sub resources (h…
d8a8e8e 
…ashicorp#11610)

implemented ResourceImporter for sub resources which extracts the lb id
deprecated location on each sub resource as it was unused
@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/azurerm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmcatominey @stack72