Add input block schema and deprecate variable block #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the schema for the `input` block in a stack configuration file and deprecates the `variable` block. The `variable` block has been replaced with the `input` block. The `input` block allows users to customize aspects of the stack that differ between deployments.
ansgarm
requested changes
Aug 5, 2024
Comment on lines
+18
to
+21
| bs.Blocks["variable"].IsDeprecated = true | ||
| bs.Blocks["variable"].Description = lang.Markdown("The `variables` attribute has been replaced with the `inputs` attribute. Please update the configuration to use `inputs` instead of `variables`, as support for the `variables` attribute will be removed entirely before the final release of Terraform Stacks.") | ||
|
|
||
| bs.Blocks["input"] = inputBlockSchema() |
There was a problem hiding this comment.
Hm, I don't think that's correct – The block used to declare inputs is still called variable (as per Liams latest branch updating the syntax).
We'd need to deprecate & update the variables and inputs attributes within component and deployment blocks instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the schema for the
inputblock in a stack configuration file and deprecates thevariableblock.The
variableblock has been replaced with theinputblock. Theinputblock allows users to customize aspects of the stack that differ between deployments.